Fix in showing Values

On first creation of the victron-client, the showValues and contextStore get defaults. Updated examples.
victronenergy · Nov 7, 2024 · 1ce472e · 1ce472e
1 parent 4406fd1
commit 1ce472e
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/examples/Virtual Device: grid.json b/examples/Virtual Device: grid.json
@@ -1,7 +1,7 @@
 [
     {
         "id": "82af4d599bf0380c",
-        "type": "Virtual Device",
+        "type": "victron-virtual",
         "z": "456c3da89ebad689",
         "name": "P1",
         "device": "grid",

diff --git a/examples/Virtual Device: meteo.json b/examples/Virtual Device: meteo.json
@@ -307,7 +307,7 @@
     },
     {
         "id": "965441bc584a2726",
-        "type": "Virtual Device",
+        "type": "victron-virtual",
         "z": "de710832a415f877",
         "name": "",
         "device": "meteo",

diff --git a/examples/Virtual Device: tank.json b/examples/Virtual Device: tank.json
@@ -1,7 +1,7 @@
 [
     {
         "id": "f5bdb1bb02f4d6dc",
-        "type": "Virtual Device",
+        "type": "victron-virtual",
         "z": "a442aa86b4030805",
         "name": "Water",
         "device": "tank",

diff --git a/src/nodes/config-client.html b/src/nodes/config-client.html
@@ -63,7 +63,7 @@
         category: 'config',
         color: '#a6bbcf',
         defaults: {
-          showValues: { value: false },
+          showValues: { value: true },
           contextStore: {value: true }
         },
         label: function label() {

diff --git a/src/nodes/victron-nodes.html b/src/nodes/victron-nodes.html
@@ -377,7 +377,9 @@
                         id: "victron-client-id",
                         _def: RED.nodes.getType("victron-client"),
                         type: "victron-client",
-                        users: []
+                        users: [],
+                        "showValues": true,
+                        "contextStore": true
                     };
                     RED.nodes.add(victronClientNode);
                     RED.nodes.dirty(true);

diff --git a/src/nodes/victron-nodes.js b/src/nodes/victron-nodes.js
@@ -149,7 +149,7 @@ module.exports = function (RED) {
           if (this.pathObj.type === 'enum') {
             text = `${value} (${this.pathObj.enum[value]})`
           }
-          if (this.configNode && this.configNode.showValues) {
+          if (this.configNode && (this.configNode.showValues || typeof this.configNode.showValues === 'undefined')) {
             this.node.status({ fill: 'green', shape, text })
           }
         }