Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt 5 #452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mqtt 5 #452

wants to merge 2 commits into from

Conversation

mman
Copy link
Collaborator

@mman mman commented Oct 8, 2024

Closes #450 to support integration of https://github.com/victronenergy/victron-mfd-modules/pull/18

After much investigation it turns out that two fixes are required:

  1. Importing polyfill for AbortSignal and AbortController. That one is pretty straightforward.
  2. Transforming XXXn JS bigint literals to BigInt("XXX") to avoid syntax errors in older browser.
  3. Importing polyfill for globalThis from @ungap/global-this. That one is not straightforward at all because we are already compiling the app with webpack/babel/babel-loader and targeting Chrome >=45, so resulting JavaScript correctly includes globalThis polyfill from core-js library. It is also used where needed. But turns out that babel in our build is getting confused somehow and does not properly reference the globalThis polyfill in mqtt dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: npm run build should produce ES5 code to properly support old MFDs
1 participant