Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450 to support integration of https://github.com/victronenergy/victron-mfd-modules/pull/18
After much investigation it turns out that two fixes are required:
AbortSignal
andAbortController
. That one is pretty straightforward.XXXn
JS bigint literals toBigInt("XXX")
to avoid syntax errors in older browser.globalThis
from @ungap/global-this. That one is not straightforward at all because we are already compiling the app withwebpack/babel/babel-loader
and targeting Chrome >=45, so resulting JavaScript correctly includesglobalThis
polyfill fromcore-js
library. It is also used where needed. But turns out that babel in our build is getting confused somehow and does not properly reference theglobalThis
polyfill inmqtt
dependency.