Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus_generator test run stops at midnight #279

Closed
izak opened this issue May 9, 2018 · 1 comment
Closed

dbus_generator test run stops at midnight #279

izak opened this issue May 9, 2018 · 1 comment
Assignees
@izak

Comments

@izak
Copy link
Collaborator

izak commented May 9, 2018

The trouble is here. today jumps 24 hours ahead at midnight and with it the entire window. One second past midnight will always be outside that window.
@izak izak self-assigned this May 9, 2018
izak added a commit to victronenergy/dbus_generator that referenced this issue May 11, 2018
@izak
Don't stop test runs at midnight.
a905f42 
Without this, the generator will stop at midnight as the testrun window jumps
into the next day. By checking if the current time falls in yesterday's window
we take care of this anomaly.

victronenergy/venus#279
@izak
Copy link
Collaborator Author

izak commented Jun 11, 2018

Fixed in v2.20~32.

@izak izak closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izak izak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@izak