feat: Added support to Android via Termux App #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicwomg
reviewed
Nov 22, 2024
vicwomg
reviewed
Nov 22, 2024
vicwomg
reviewed
Nov 22, 2024
vicwomg
reviewed
Nov 22, 2024
vicwomg
reviewed
Nov 22, 2024
vicwomg
changed the title
|
Great! Just had a few suggested changes. I will add the Android guide to the wiki |
…o a function / use lowecase convention for android / Generalize the error CPU usage query not supported / Use precise statement '==' vs 'in'
|
I've addressed the requested changes. Please review them when you have time. Thank you! |
vicwomg
added a commit
that referenced
this pull request
Nov 23, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](1.5.2...1.6.0) (2024-11-23) ### Features * Added support to Android via Termux App ([#423](#423)) ([0118733](0118733)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to Android via the Termux App.
lib/app.py
Handle error when querying cpu usage on Termux (restricted)
Force to run on headless mode when detected running on Android.
karaoke.py
Added way to query ip address when running on Termux/Android since sockets will not work.
get_platform.py
is_raspberry_pi(): Added validation to avoid incorrectly reporting Termux/Android as raspberry pi.
get_platform(): Properly returns Android as platform to avoid crashes in other program logic.
scripts/README.md
Added Termux/Android installation.