Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cell ID in the UI #3

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Conversation

krassowski
Copy link

This is aimed to help with jupyter#639. The cell ID will now be shown above the modified cells:

Screenshot from 2023-06-10 20-50-08

@krassowski
Copy link
Author

Hi @vidartf just checking if you saw this one. Any thoughts?

@vidartf
Copy link
Owner

vidartf commented Jul 7, 2023

Sorry I missed this! Thanks for the help! I think it looks good in principle, but these thoughts:

  • The way I read this, it only shows the cell IDs if they have changed.
  • If it is only shown when changed (which is a rare occurrence), it will be rare for users to see them. Will they then:
    • Know what it means?
    • Notice them?

Potential ways to address above points:

  • Color highlight them? It might be hard to get this right unless we highlight the entire header, and that might be confusing.
  • Use a stronger font color (the current color2 is rather unimposing, while we might wish to draw more attention to it).
  • Have a label "Cell ID", or tooltip "Cell ID changed"? Something indicating to the user what this weird string of random characters are, and maybe why it is a big deal?

@vidartf vidartf merged commit bf9742b into vidartf:cellid-diff Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants