Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 2 and FIX: #22 - AttributeError: module 'docutils.nodes' has no attribute '… #23

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Drop support for python 2 and FIX: #22 - AttributeError: module 'docutils.nodes' has no attribute '… #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72657f8
FIX: #22 - AttributeError: module 'docutils.nodes' has no attribute '…
antoinecollet5 May 22, 2024
575f8ec
Update __init__.py - fix typo
antoinecollet5 May 22, 2024
04154bd
Drop python 2 support
antoinecollet5 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions nbsphinx_link/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from nbsphinx import NotebookParser, NotebookError, _ipynbversion
import nbformat
from sphinx.util.logging import getLogger

from ._version import __version__


Expand Down Expand Up @@ -189,7 +188,6 @@ def parse(self, inputstring, document):

abs_path = os.path.normpath(os.path.join(source_dir, link['path']))
path = utils.relative_path(None, abs_path)
path = nodes.reprunicode(path)

extra_media = link.get('extra-media', None)
if extra_media:
Expand All @@ -199,8 +197,7 @@ def parse(self, inputstring, document):
register_dependency(path, document)

target_root = env.config.nbsphinx_link_target_root
target = utils.relative_path(target_root, abs_path)
target = nodes.reprunicode(target).replace(os.path.sep, '/')
target = utils.relative_path(target_root, abs_path).replace(os.path.sep, '/')
env.metadata[env.docname]['nbsphinx-link-target'] = target

# Copy parser from nbsphinx for our cutom format
Expand Down
15 changes: 9 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,19 @@
license = 'BSD-3',
platforms = "Linux, Mac OS X, Windows",
keywords = ['Interactive', 'Interpreter', 'Shell', 'Web'],
classifiers = [
classifiers=[
'Intended Audience :: Developers',
'License :: OSI Approved :: BSD License',
'Programming Language :: Python',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
],
python_requires=">=3",
install_requires = [
'nbsphinx',
'sphinx>=1.8',
Expand Down