fix(function-rule): return success if the function rule is undefined

vidavidorra · Apr 17, 2022 · 82047c3 · 82047c3
1 parent 84e415f
commit 82047c3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/function-rule.test.ts b/src/function-rule.test.ts
@@ -29,7 +29,7 @@ test('returns a value from an implementation function', (t) => {
   t.deepEqual(returnValue, ruleOutcome);
 });
 
-test.failing('returns successful for an undefined implementation', (t) => {
+test('returns successful for an undefined implementation', (t) => {
   const returnValue = functionRule({} as Commit, 'always', undefined);
   t.deepEqual(returnValue, [true]);
 });

diff --git a/src/function-rule.ts b/src/function-rule.ts
@@ -13,13 +13,16 @@ type FunctionRule = (
 const functionRule: Rule<FunctionRule> = (
   parsed: Commit,
   when: RuleConfigCondition = 'always',
-  value: FunctionRule | undefined,
+  functionRule: FunctionRule | undefined,
 ) => {
-  if (typeof value !== 'function') {
+  if (functionRule === undefined) {
+    return [true];
+  }
+  if (typeof functionRule !== 'function') {
     throw new Error('Not a valid function!');
   }
 
-  return value(parsed, when);
+  return functionRule(parsed, when);
 };
 
 export default functionRule;