Skip to content
This repository was archived by the owner on Nov 13, 2022. It is now read-only.

Expose commands to control RecentFilesView selection #18

Merged
merged 3 commits into from
Jan 18, 2017

Conversation

forceuser
Copy link
Contributor

@forceuser forceuser commented Jan 17, 2017

This pull request exposes selectNextItemView() and confirmSelection() of RecentFilesView commands to control RecentFilesView selection, to make this package more configurable
For example i want to configure switching between recent files with just one key shortcut (ctrl-tab, like in NetBeans), this is keymap.cson example for this configuration

'atom-workspace':
  'ctrl-tab': 'recent-files-fuzzy-finder:toggle-finder'
  'ctrl-tab ^ctrl': 'unset!'
'.recent-files-fuzzy-finder':
  'ctrl-tab': 'recent-files-fuzzy-finder:select-next-item'
  'ctrl-escape': 'recent-files-fuzzy-finder:toggle-finder'
  '^ctrl': 'recent-files-fuzzy-finder:confirm-selection'

I have also added .recent-files-fuzzy-finder class to the RecentFilesView, to manage keymaps only for it

@viddo
Copy link
Owner

viddo commented Jan 18, 2017

Nice one! 👌

I've noticed that the coffeelinter and an (unrelated) test case also fails on master, so I'll go ahead and merge this and fix those things separately. I'll do the release ASAP I have that sorted out.

Thanks! 🙇

@viddo viddo merged commit 5c91587 into viddo:master Jan 18, 2017
@viddo
Copy link
Owner

viddo commented Jan 18, 2017

FYI: https://github.com/viddo/recent-files-fuzzy-finder/pull/19/files#diff-04c6e90faac2675aa89e2176d2eec7d8R29

Let me know if something looks wrong. Otherwise I'll merge and release this once Travis goes green (probably sometime tomorrow morning).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants