Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add keyword search, scene index #58

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Feat: add keyword search, scene index #58

merged 5 commits into from
Nov 12, 2024

Conversation

ankit-v2-3
Copy link
Collaborator

@ankit-v2-3 ankit-v2-3 commented Nov 6, 2024 •
edited
Loading

  • Add keyword search and scene index.
  • Add Search configuration params.
  • Add Scene index configuration and prompt.

@ankit-v2-3 ankit-v2-3 linked an issue Nov 6, 2024 that may be closed by this pull request
Search type and parameters support #52
Closed
1 task
@ankit-v2-3 ankit-v2-3 changed the title draft: add keyword search, scene index Feat: add keyword search, scene index Nov 12, 2024
@ashish-spext
Copy link
Contributor

Can we add ability for user to give custom index prompt? we can fallback on the default if not given

  1. There can be cases where user need to change the prompt case by case.
  2. It will be useful when user wants to compare the prompt performance for finalizing it.

@ankit-v2-3
Copy link
Collaborator Author

Yeah, Now user can give custom indexing prompt.

@ashish-spext
Copy link
Contributor

Keyword Search the word "Tarantino" and make a clip search working fine

Query Find the scenes with tarantino failed and got error

  1. The loading states of video and summary are not updated with fail status.
    image
    Error trace:
/backend/director/agents/search.py", line 129, in run
[BACKEND]     search_results = videodb_tool.keyword_search(
[BACKEND]                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[BACKEND] <html lang=en>
[BACKEND] <title>500 Internal Server Error</title>
[BACKEND] <h1>Internal Server Error</h1>
[BACKEND] <p>The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.</p>
[BACKEND]
[BACKEND] emitting event "chat" to njTu4cOMhFOU2Z88AAAB [/chat]
  1. It selected keyword search instead of scene search. (is it one off issue or happened with you as well? I will observe some more)

Along with above fix, can we give some indication in action of which search type is selected?

@ankit-v2-3
Copy link
Collaborator Author

  1. Is it happening on all the failed searches?

  2. We have keyword and semantic search on scene index and your query was to Find the scenes with tarantino it selected the correct search type on scene index.

Also I've add search type indication in director's log.

@ashish-spext
Copy link
Contributor

ashish-spext commented Nov 12, 2024 •
edited
Loading

  1. Git pull resolved it, the commit while testing was older.
  2. Cool I didn't notice the index_type (action message resolved this)

@ankit-v2-3 ankit-v2-3 merged commit d9e6b1f into main Nov 12, 2024
@ankit-v2-3 ankit-v2-3 deleted the 52-search-type-and-parameters-support branch November 14, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-spext ashish-spext ashish-spext approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search type and parameters support
2 participants
@ankit-v2-3 @ashish-spext