Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dubbing agent & elevenlabs tools #59

Merged
merged 6 commits into from
Nov 13, 2024
Merged

add dubbing agent & elevenlabs tools #59

merged 6 commits into from
Nov 13, 2024

Conversation

0xrohitgarg
Copy link
Collaborator

@0xrohitgarg 0xrohitgarg commented Nov 8, 2024 •
edited
Loading

closes : #36

ashish-spext
ashish-spext approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ashish-spext ashish-spext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Tested on a video.

Just requested minor stylistic updates, let's merge it once done.

backend/director/agents/dubbing.py Outdated Show resolved Hide resolved
backend/director/agents/dubbing.py Outdated Show resolved Hide resolved
backend/director/agents/dubbing.py Outdated Show resolved Hide resolved
@ashish-spext
Copy link
Contributor

ashish-spext commented Nov 13, 2024 •
edited
Loading

Can elevenlabs give us a download URL instead of local file download?
If yes that can speed up the upload process of last step.

@0xrohitgarg
Copy link
Collaborator Author

@ashish-spext , no option present to get download url on this endpoint Get Dubbed File,
Also no option present in Dub a video or endpoint

Notes for optimization for later:

  • Try Dub a Audio endpoint, excepting that it can reduce elevenlabs processing time
  • Try text to speech api endpoint

@0xrohitgarg 0xrohitgarg merged commit ad39c79 into main Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-spext ashish-spext ashish-spext approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dubbing Agent
2 participants
@0xrohitgarg @ashish-spext