Calling detatchMedia() followed by attachMedia() causes audio to not play #2099
Labels
Milestone
Comments
|
It's fMP4 HLS. |
|
@itsjamie Indeed it is. How is that an issue here though? The methods should still work here. |
|
Audio track on re-attaching does: |
|
Just it goes through a different code path because it doesn't run through the tsdemuxer. |
3 tasks
|
So I found a issue... In the buffer controller on first load However, if I just add a local variable to persist this alternate audio, so that it expects the same on detach/attach scenario it doesn't fix the issue. |
3 tasks
5 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bot, this is still an issue. |
|
👍
…On Thu, Apr 4, 2019 at 07:37 Brandon Kalinowski ***@***.***> wrote:
Bot, this is still an issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2099 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEzwZKdb1plHhDtFH4rbRn-CTQ9D1tF3ks5vdeQVgaJpZM4aTsey>
.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still relevant |
OrenMe
added a commit
that referenced
this issue
Jul 15, 2019
… not play On re-attch the context of altAudio is not saved in buffer control so it doesn't know to create two source buffers. Also, in context of stream controller it doesn't reset the `altAudio` flag. I also noticed that stream controller is reloading the entire frags it has in `fragmentTracker` and it seems it needs to be reset on detach, otherwise there's a very long start delay where unncessery buffering occurs. based on #2110 and fixes #2099.
3 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This was referenced Jun 6, 2021
1 task
This was referenced Aug 13, 2022
1 task
This was referenced Nov 4, 2022
1 task
github-actions bot
pushed a commit
to teiron-1604/hls.js
that referenced
this issue
Feb 26, 2025
# 1.0.0 (2025-02-26) * [JW8-6113] Implement progressive AES decryption ([video-dev#219](https://github.com/teiron-1604/hls.js/issues/219)) ([1050e74](1050e74)) ### Bug Fixes * `setMediaKeys` return undefined in some Chrome versions ([video-dev#6669](https://github.com/teiron-1604/hls.js/issues/6669)) ([1d10714](1d10714)) * abrFactor greater than in docs ([1adc39e](1adc39e)) * afterEach callback should return a promise ([44aa769](44aa769)) * baseMediaDecodeTime in tfdt v0 should not be re-written to a negative value ([b884798](b884798)) * calling detatchMedia() followed by attachMedia() causes audio to not play ([161c66c](161c66c)), closes [video-dev#2099](https://github.com/teiron-1604/hls.js/issues/2099) * catch exception ([715ca74](715ca74)) * change test streams hosting to mux ([video-dev#2307](https://github.com/teiron-1604/hls.js/issues/2307)) ([25f0bbe](25f0bbe)) * **ci:** invalid branch ([5c20968](5c20968)) * computeLivePosition minimum value of media.currentTime ([3fd87fe](3fd87fe)) * consider paused state ([b58c595](b58c595)), closes [video-dev#2417](https://github.com/teiron-1604/hls.js/issues/2417) * contiguous detection error ([2a9180d](2a9180d)) * Delete unused var ([9d3beb9](9d3beb9)) * **demo:** update http to https ([9327fc6](9327fc6)) * **deps:** update to esdoc@1.1.0 ([ad6a9e6](ad6a9e6)) * **docs:** fix links to src ([b82e921](b82e921)) * duplicate segmented vtt lines ([a25f0b1](a25f0b1)) * failed to switch back to main audio from additional audio ([video-dev#5170](https://github.com/teiron-1604/hls.js/issues/5170)) ([6e157ac](6e157ac)) * Fix indent ([6eb6eaf](6eb6eaf)) * fix live playlist not sync ([938606f](938606f)) * **func-test:** add "firefox" to black_list of angelOneShakaWidevine ([cb6e22e](cb6e22e)) * **func-test:** add `nudgeMaxRetry` option for slow seek env ([aca699c](aca699c)) * generate silent aac frame based on original codec ([video-dev#6123](https://github.com/teiron-1604/hls.js/issues/6123)) ([b721af3](b721af3)) * initial segment change without discontinuity ([ab9651e](ab9651e)) * **latency-controller:** only sync live stream ([d3845c2](d3845c2)) * level playlist parse error due to "rawProgramDateTime" of initial segment not reset ([a4b4f5f](a4b4f5f)) * lost program date time. ([7fef02c](7fef02c)) * move `types` condition to the front ([video-dev#5439](https://github.com/teiron-1604/hls.js/issues/5439)) ([9082342](9082342)) * **mp4-tools:** Fix two AV1 parsing issues ([video-dev#5774](https://github.com/teiron-1604/hls.js/issues/5774)) ([c9e9916](c9e9916)) * Not set initial segment for part and hint segments ([3331d6f](3331d6f)) * partial audiovideo fragments not being treated as partial ([video-dev#5460](https://github.com/teiron-1604/hls.js/issues/5460)) ([ef718d2](ef718d2)) * remove redundant code ([d8d684d](d8d684d)) * remove uneeded tests ([95f32a1](95f32a1)) * Remove unnecessary option ([video-dev#2273](https://github.com/teiron-1604/hls.js/issues/2273)) ([f723c06](f723c06)) * **Remuxer:** Safari segment overlap ensure PTS order ([video-dev#6132](https://github.com/teiron-1604/hls.js/issues/6132)) ([af42912](af42912)) * Replace Loader.getResponseHeader() with Loader.getCacheAge(). ([d520008](d520008)) * Replace tab to space ([6eec3df](6eec3df)) * set initial segment repeatedly for ll-hls stream ([78de428](78de428)) * show cc with low latency stream. ([6e23bd0](6e23bd0)) * stopLoad() after destroy() becomes no-op, startLoad() after destroy() throws nicer error message. ([0c32415](0c32415)) * StreamController#stop should call clearInterval ([1aa78bf](1aa78bf)) * **subtitle:** vtt fragment sn is consistent with ts, no need to request previous fragment sn ([6d1f3db](6d1f3db)) * the functional tests for "MPEG Audio Only demo" failed ([732c2c3](732c2c3)) * **timeline-controller:** reuse text tracks when not in same order ([video-dev#1869](https://github.com/teiron-1604/hls.js/issues/1869)) ([6db0112](6db0112)) * tizen 2017 widevine playback ([video-dev#6657](https://github.com/teiron-1604/hls.js/issues/6657)) ([f167465](f167465)) * type name error ([video-dev#5295](https://github.com/teiron-1604/hls.js/issues/5295)) ([91364bb](91364bb)) * **types:** Remove unused Loader.loader property. ([fb1ead0](fb1ead0)) * **type:** use extended generic type `LoaderContext` in type `Loader` ([video-dev#5487](https://github.com/teiron-1604/hls.js/issues/5487)) ([075e834](075e834)) * typo ([f769aac](f769aac)) * unit test fail, observer.emit is not a function ([6b85ffa](6b85ffa)) * use hasInterval instead of isNaN ([a9e6c45](a9e6c45)) * using implicit return ([4bf6ee9](4bf6ee9)) * vtt parser broke after master merge ([e96a2a1](e96a2a1)) * X-EXT-MAP in between duration and url ([d7e90c6](d7e90c6)) * X-EXT-MAP in between duration and url ([078fddc](078fddc)) ### Code Refactoring * Remove loader.getResponseHeader(). ([ca962e5](ca962e5)) ### Features * add hasFragment and removeAllFragments ([3ae3aa3](3ae3aa3)) * add support for CMCD nor ([video-dev#6091](https://github.com/teiron-1604/hls.js/issues/6091)) ([763c129](763c129)), closes [video-dev#6088](https://github.com/teiron-1604/hls.js/issues/6088) * add support for decrypting init segments. ([41addd9](41addd9)), closes [video-dev#2259](https://github.com/teiron-1604/hls.js/issues/2259) * Add supported M3U8 tags ([2ca6bb8](2ca6bb8)) * add type to discontinuities.js and fix @typescript-eslint/prefer-optional-chain error ([ad1bbef](ad1bbef)) * **ci:** add release workflow ([154409c](154409c)) * Format code by Prettier ([993ef82](993ef82)) * **level:** deliver level details when level switches ([55e4dbc](55e4dbc)) * using ts assert instead of runtime code changes ([0674273](0674273)) ### Performance Improvements * for .. of to simple for iteration ([409a1ab](409a1ab)) * inlining bufferedIncludesPosition ([ad5bfa1](ad5bfa1)) * pre-cache buffered positions ([03aa7ec](03aa7ec)) * use helper function to filter evicted fragments ([34190c0](34190c0)) ### Reverts * Revert "buffer-helper: correctly report bufferInfo when current time is located before buffered ranges, but within maxHoleDuration range" ([877f1c6](877f1c6)), closes [video-dev#420](https://github.com/teiron-1604/hls.js/issues/420) * Revert "config defaults: set maxBufferHole to 15 second" ([8acc166](8acc166)) * Revert "Configure rennovate to `pinGitHubActionDigests`" ([2c993b1](2c993b1)) * Revert "Disable `AppleAdvancedHevcAvcHls` stream for now due to cors errors (…" ([video-dev#6187](https://github.com/teiron-1604/hls.js/issues/6187)) ([efb252c](efb252c)) * Revert "functional test: run against Safari 10.0" ([be5d7c5](be5d7c5)) * Revert "switch to npm 7 ([video-dev#3666](https://github.com/teiron-1604/hls.js/issues/3666))" ([video-dev#3671](https://github.com/teiron-1604/hls.js/issues/3671)) ([2e3f6f3](2e3f6f3)) ### BREAKING CHANGES * Remove loader.getResponseHeader() in favor of loader.getCacheAge(). * force software AES decrypter if config is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Hls.js are you using?
0.12.2
What browser and OS are you using?
Chrome and Firefox for Mac
Test stream:
This is the stream:
https://demo.unified-streaming.com/video/tears-of-steel/tears-of-steel-fmp4.ism/.m3u8
And here it is on the demo page:
https://hls-js.netlify.com/demo/?src=https%3A%2F%2Fdemo.unified-streaming.com%2Fvideo%2Ftears-of-steel%2Ftears-of-steel-fmp4.ism%2F.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOnRydWUsImVuYWJsZVdvcmtlciI6dHJ1ZSwiZHVtcGZNUDQiOmZhbHNlLCJsZXZlbENhcHBpbmciOi0xLCJsaW1pdE1ldHJpY3MiOi0xLCJ3aWRldmluZUxpY2Vuc2VVcmwiOiIifQ==
Checklist
Steps to reproduce
I am working on testing out midroll ads. Currently I must destroy the hls instance, play the ad (a simple mp4) and then reinitialize the hls streamer. I would prefer to avoid this method as it causes the buffer to be thrown out on the main HLS video.
However, calling
hls.detatchMedia()followed byhls.attachMedia(document.getElementById('video'))causes the audio to stop playing.Ocassionally this instead causes only the the audio to play when the hls is reattached and the video element will be black. However, this is hard to reproduce, and for the most part it is usually the case where the audio is the track that is missing. Of course, both cases I would consider to be a bug.
100% of the time.
Expected behavior
What you expected to happen
Attaching the hls to the player should not cause issues with playback.
Actual behavior
What actually happened
Audio did not play after reattaching media to the video element. Rarely, audio played but video did not. It was never the case that both played at once.
Console output
Paste the contents of the browser console here.
For media errors reported on Chrome browser, please also paste the output of chrome://media-internals
The text was updated successfully, but these errors were encountered: