Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment + Playlist loaders are not always destroyed before freeing #2104

Closed
5 tasks done
mfedderly opened this issue Jan 28, 2019 · 1 comment · Fixed by #3628
Closed
5 tasks done

Fragment + Playlist loaders are not always destroyed before freeing #2104

mfedderly opened this issue Jan 28, 2019 · 1 comment · Fixed by #3628
Labels
Bug Confirmed Bug report confirmed or reproduced.
Milestone

Comments

@mfedderly
Copy link
Contributor

What version of Hls.js are you using?

0.11.0

What browser and OS are you using?

Chrome

Checklist

  • The stream has correct Access-Control-Allow-Origin headers (CORS)
  • There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

  1. Implement a custom loader that has resources that must be freed when the loader is no longer in use
  2. Notice that the fragment and playlist loaders are created but not destroyed due to memory leak

Expected behavior

Before freeing a loader instance, the destroy method is called

Actual behavior

The loader is freed without calling destroy first

@itsjamie
Copy link
Collaborator

Link #2123.

@itsjamie itsjamie added Bug Confirmed Bug report confirmed or reproduced. labels Feb 14, 2019
@robwalch robwalch added this to the 1.0.0 milestone Mar 17, 2021
robwalch pushed a commit that referenced this issue Mar 17, 2021
@robwalch robwalch mentioned this issue Mar 17, 2021
3 tasks
robwalch pushed a commit that referenced this issue Mar 17, 2021
robwalch pushed a commit that referenced this issue Mar 17, 2021
robwalch pushed a commit that referenced this issue Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed Bug report confirmed or reproduced.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants