-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progressive mode is broken with fmp4 playback #4317
Comments
@kedanielwu thanks for reporting, I dug into this a bit, looks to be a regression between 1.0.0 and 1.0.1: (Add Here's 1.0.0 permalink with
[bug] Here's 1.0.1 permamlink with
Based on that, it appears the regression was introduced in this v1.0.1 release. Here's the diff There was a fix for
|
@dylanjha thanks for the information, I will take a look into this and hopefully provide a fix. |
What version of Hls.js are you using?
1.0.10
What browser (including version) are you using?
Chrome 93.0.4577.63 (Official Build) (x86_64)
What OS (including version) are you using?
MacOS 11.3
Test stream
https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s-fmp4/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
Expected behaviour
the video should play correctly
What actually happened?
video stuck at loading, and warning can be found in the console
So basically what I found is in base-stream-controller, no onprogress callback is provided when trying to load initSegement, while the fetch-loader, in this case, will resolve the load promise with empty data and calling onsuccess.
In our own forked version, what I did is forcing fetch-loader to go through the 'full' load path when fragment sn is initSegment, by setting highwatermark to Infinity or by removing onprogress callback. And this seems fixed the issue.
I don't think this is a proper fix, but I think I need some knowledge to fully understand the issue. would there be any risk when trying to progressively load initSegement?
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: