Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix a couple of end of stream issues with ll-hls content to ensure ended will still occur.
I've also created a simple TimeRangesMock for the testing side.
Since this is an ENDLIST/end of stream issue, I can't provide a test stream, but I can assist with starting/ending ll-hls streams for reviewers if needed (I'm in Chicago/US Central Time for a rough sense of availability)
Why is this Pull Request needed?
The conditions for detecting end of stream for are insufficient ll-hls content, which results in a stall instead of ended. Part of this is related to the fact that fragCurrent for playlists with parts may in fact be "ahead" of the current endSN. Part of this is because FragmentTracker/its usage to determine endOfStream does not account for parts.
Are there any points in the code the reviewer needs to double check?
I'm currently relying on the levelDetails.partList to detect end of stream conditions.
activeParts
when they're buffered, evicted, etc, so this would be a much larger effort. I've confirmed that we could check the last activePart against the relevant timeRanges ingetState()
, but this feels too operationally intensive for that method, something likeResolves issues:
Fixes #4463
Checklist