Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve linting issue causing build to fail. #4604

Merged
merged 3 commits into from
Mar 22, 2022

Conversation

itsjamie
Copy link
Collaborator

This PR will...

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@tjenkinson
Copy link
Member

good spot. There are a few warnings but the block was prettier which should be fixed with b50e087

@itsjamie itsjamie merged commit 630865e into master Mar 22, 2022
@itsjamie itsjamie deleted the resolve-lint-unused-failures branch March 22, 2022 14:15
@itsjamie
Copy link
Collaborator Author

Build passed and functional test passed. So merging to unblock external PRs from getting ✅ 'd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants