Fix for Issue #4665 #4666
Merged
Fix for Issue #4665 #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Jul 12, 2022
| @@ -158,8 +158,8 @@ export default class Decrypter { | |||
| if (!subtle) { | |||
| return Promise.reject(new Error('web crypto not initialized')); | |||
| } | |||
|
|
|||
| const crypto = new AESCrypto(subtle, iv); | |||
| this.logOnce('WebCrypto AES decrypt'); | |||
There was a problem hiding this comment.
Please remove new log messages.
|
|
||
| const crypto = new AESCrypto(subtle, iv); | ||
| this.logOnce('WebCrypto AES decrypt'); | ||
| const crypto = new AESCrypto(subtle, new Uint8Array(iv)); |
There was a problem hiding this comment.
If Webcrypto requires an ArrayBufferView in some cases, let's make all our methods strongly typed to require a Uint8Array explicitly. That way we're not extracting the buffer in our stream controllers which call webCryptoDecrypt and we're just passing the original view through all places where we're passing iv (decrypt, softwareDecrypt, and here).
Merged
3 tasks
robwalch
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve issue webcrypto usage reverting to software aes decrypt.
Why is this Pull Request needed.
Webcrypto compatibility for Webkit based browsers.
Are there any points in the code the reviewer needs to double check?
Best practice around calling new proto for each AES decrypt action.
Resolves issues: #4665
Checklist