Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttle audio stream controller based on main buffer state #4809

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Throttle audio stream controller based on main buffer state #4809

merged 1 commit into from
Jul 27, 2022

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 22, 2022 •
edited
Loading

This PR will...

  • Buffer audio up to one target duration ahead of main buffer
  • Wait for main buffer after buffing some audio

Why is this Pull Request needed?

Improve efficiency for better start, seek, and adaptation times in HLS streams with alt-audio playlists.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.2.0 milestone Jul 22, 2022
@robwalch robwalch force-pushed the feature/throttle-alt-audio-fetch-based-on-main branch from 0d1be41 to db090c2 Compare July 26, 2022 23:29
@robwalch robwalch merged commit 85daa49 into master Jul 27, 2022
@robwalch robwalch deleted the feature/throttle-alt-audio-fetch-based-on-main branch July 27, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpillsbury cjpillsbury Awaiting requested review from cjpillsbury

@itsjamie itsjamie Awaiting requested review from itsjamie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch