fix sidx duration #4849
Merged
fix sidx duration #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Aug 15, 2022
src/loader/playlist-loader.ts
Outdated
Comment on lines
547
to
548
| const moovBox = findBox(data, ['moov'])[0]; | ||
| const moovEndOffset = moovBox ? moovBox.length : null; // we need this in case we need to chop of garbage of the end of current data |
There was a problem hiding this comment.
Can these moovBox, moovEndOffset lines be moved into the if (frag.initSegment) { block below since they are not used otherwise?
There was a problem hiding this comment.
Done. Ive also deleted the comment because i think its obvious what are we trying to do now.
robwalch
approved these changes
Aug 16, 2022
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix calculation of the duration of a segment which contains multiple sidx atoms (multiple fragments in a single m4s file).
Why is this Pull Request needed?
Calculation of the duration based on sidx has a bug.
Are there any points in the code the reviewer needs to double check?
parseSegmentIndexis refactored to be more cohesive and only parse sidx data.moovEndOffsetfield has been removed fromSidxInfo.Calculation of the moov offset has been moved to
handleSidxRequest.Resolves issues:
Checklist