Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize key and segment requests #4861

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

robwalch
Copy link
Collaborator

This PR will...

Load keys and encrypted segments at the same time when not loading parts or progressively.

Why is this Pull Request needed?

Reduce time to buffer encrypted content.

@robwalch robwalch added this to the 1.3.0 milestone Aug 24, 2022
@robwalch robwalch requested a review from itsjamie August 24, 2022 17:52
itsjamie
itsjamie previously approved these changes Aug 25, 2022
Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

I tested on branch with some of the AES encrypted test content, and continues to work. I also see the parallel downloading.

In my case would have netted about 62ms back on TTFF. 🎉

@robwalch
Copy link
Collaborator Author

Related #3900

@robwalch robwalch changed the base branch from master to feature/drm-key-systems-with-fps September 2, 2022 21:52
@robwalch robwalch changed the base branch from feature/drm-key-systems-with-fps to master September 2, 2022 21:53
@robwalch robwalch dismissed itsjamie’s stale review September 2, 2022 21:53

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants