Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add kaltura player to players list #5125

Merged
merged 12 commits into from
Jan 3, 2023

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Dec 21, 2022

This PR will...

add kaltura player to players list in README.md

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Checklist

  • [ x] changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes failed the lint check. Please run prettier (npm run prettier) and commit the formatting changes:
https://github.com/video-dev/hls.js/actions/runs/3750531239/jobs/6376269421

@robwalch robwalch added this to the 1.3.0 milestone Dec 22, 2022
@robwalch
Copy link
Collaborator

robwalch commented Dec 23, 2022

Thanks for fixing the lint warnings. My previous comment was to fix the prettier formatting error in the README file which is still breaking the build.

Checking formatting...
[warn] README.md
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.

npm run prettier will apply the style fixes.

@robwalch robwalch merged commit 9f4b829 into video-dev:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants