Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light build optimizations and fixes #5160

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Light build optimizations and fixes #5160

merged 1 commit into from
Jan 17, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jan 14, 2023 •
edited
Loading

This PR will...

  • Reduce hls.light build size by removing level-key, mediakeys-helper and requestMediaKeySystemAccess code
  • Fix: Allow hls.light to play Variant Playlist content while ignoring audio Media Playlists (buffer-controller expected 2 bufferCodec events, preventing playback from starting)
    • Increase number of functional tests for hls.light build to cover this case

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)

@robwalch robwalch added this to the 1.3.1 milestone Jan 14, 2023
@robwalch
Copy link
Collaborator Author

Related to #4936

@robwalch robwalch modified the milestones: 1.3.1, 1.4.0 Jan 17, 2023
@robwalch robwalch merged commit 7733355 into master Jan 17, 2023
@robwalch robwalch deleted the bugfix/light-build-fixes branch January 17, 2023 05:04
robwalch added a commit that referenced this pull request Jan 26, 2023
@robwalch
Light build optimizations and fixes (#5160)
0bc24ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch