Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align live playlist updates to end of last when there is no overlap #6692

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 11, 2024

This PR will...

Align live playlist updates to end of last when there is no media-sequence overlap and no PDT.

Why is this Pull Request needed?

When really short live playlists with sliding windows fail to update for longer than the duration of the sliding window, fragment times will slide back to 0 when there is no overlapping media-sequence, no overlapping discontinuity-sequence, and no program date time to sync on.

Keeping the sliding window moving forward, ahead of the playhead, ensures that streaming can continue and playback can resume when conditions are favorable and playback can resync with the live edge.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #6685
(duplicate of #5282)

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…uence/disconitinuity overlap and no PDT

Resolves #6685
(duplicate of #5282)
@robwalch robwalch added this to the 1.6.0 milestone Sep 11, 2024
@robwalch robwalch linked an issue Sep 16, 2024 that may be closed by this pull request
5 tasks
@robwalch robwalch merged commit 2b1e1aa into master Sep 17, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/live-alignment-with-no-overlap branch September 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant