Bugfix: Low-Latency false starts when part selection does not match fragment #6841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix unused part loading when selected frag passed to
_doFragLoad
is not used by part selection.Why is this Pull Request needed?
There was an expectation that
_doFragLoad(frag)
will resolve with the frag or a part from that frag being loaded. The result of_doFragLoad
is ignored ifstreamController.currentFrag
no longer matchesfrag
.This PR fixes the case where
_doFragLoad(frag)
resolves with a different fragment because of part selection needing to usefragmentHint
or an independent part in the part list belonging to another fragment:Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist