Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#EXT-X-BITRATE support #6843

Merged
merged 1 commit into from
Nov 14, 2024
Merged

#EXT-X-BITRATE support #6843

merged 1 commit into from
Nov 14, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Use segment #EXT-X-BITRATE tag value where applicable. Adds Fragment byteLength getter and bitrate getter/setter.

Why is this Pull Request needed?

Improves _abandonRulesCheck calculations when #EXT-X-BITRATE tags provide more accurate bitrate values than those found in the MVP.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Adds Fragment byteLength getter and bitrate getter/setter
@robwalch robwalch added this to the 1.6.0 milestone Nov 14, 2024
@robwalch robwalch merged commit 4b61208 into master Nov 14, 2024
15 of 16 checks passed
@robwalch robwalch deleted the feature/bitrate-tag-support branch November 14, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant