db: add support for persisting jobs on Redis #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 26, 2016 17:52
It will save the Job using a Redis hash, generating a new ID if it's not defined.
We should manage the connection in this package, this should not be a job of the config package.
The Redis driver provides a call that returns the map.
|
LGTM, especially since this includes the decisions we agreed on together while @fsouza was doing the implementation, like having the SaveJob func generate the id. |
marzagao
added a commit
that referenced
this pull request
Jan 27, 2016
db: add support for persisting jobs on Redis
flavioribeiro
pushed a commit
that referenced
this pull request
Apr 10, 2017
bumping bitmovin fork master to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each job will be a hash in Redis.