fix: include all master playlists in default audio group #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 86.47% 86.49% +0.01%
==========================================
Files 39 39
Lines 9500 9512 +12
Branches 2189 2193 +4
==========================================
+ Hits 8215 8227 +12
Misses 1285 1285
Continue to review full report at Codecov.
|
gkatsev
previously approved these changes
Jun 24, 2021
gkatsev
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends upon videojs/mux.js#388
Fixes #1034
This prevents issues where the default audio group that we add does not have any playlist attributes of it's own so our playlist switching logic throws errors when trying to access properties.