fix: on flush if a pmt has not been emitted and we have one, emit it #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Jun 23, 2021
lib/m2ts/m2ts.js
Outdated
| tracks: [] | ||
| }; | ||
| // translate audio and video streams to tracks | ||
| if (programMapTable.video !== null) { |
There was a problem hiding this comment.
looks like we need to null check programMapTable itself here and below too, likely.
There was a problem hiding this comment.
good call, I also realized that flushStreams isn't only called on flush which gave us a lot more trackinfo events than we wanted. I moved this code to this.flush and the unit tests in vhs pass 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always emit trackinfo, even if we didn't process a pmt.