Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subtitles): set default property if default and autoselect are both enabled #239

Merged
merged 3 commits into from
Oct 25, 2018
Merged

fix(subtitles): set default property if default and autoselect are both enabled #239

merged 3 commits into from
Oct 25, 2018

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Sep 24, 2018

No description provided.

@gkatsev
Copy link
Member Author

gkatsev commented Sep 24, 2018

Looking at https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-4.3.4.1, seems like propreties.default && properties.autoselect is the correct way to hint whether something should be chosen.

@forbesjo
Copy link
Contributor

LGTM, @gesinger ?

gesinger
gesinger reviewed Sep 24, 2018
View reviewed changes
Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would be worth having a couple tests around it.

@gkatsev
Copy link
Member Author

gkatsev commented Sep 24, 2018

I can try but I'm not sure I have the time to add tests to this.

@forbesjo
Copy link
Contributor

forbesjo commented Oct 4, 2018

@gkatsev I'm going to add some tests and also make the change for captions, unless default doesn't apply?

@gkatsev
Copy link
Member Author

gkatsev commented Oct 4, 2018

We can actually tell whether it should be captions or subtitles by which characteristics are enabled. If there are characteristics, particularly the value public.accessibility.describes-music-and-sound, it means it's captions and not just subtitles.

@forbesjo
Copy link
Contributor

forbesjo commented Oct 4, 2018

I'm specifically referring to https://github.com/videojs/http-streaming/blob/master/src/media-groups.js#L571

@gkatsev
Copy link
Member Author

gkatsev commented Oct 4, 2018

oh, I see. Yeah, we probably should do that there as well.

@mrocajr @forbesjo
Add unit tests and closed-caption autoselect to fix(subtitles) PR (#270)
ce2a784 
* - Added autoselect property to closed-caption default
- Added tests for autoselect for closed-caption and subtitles

* - Changed captions enabled to default

* - Check for default in test rather than enabled

* - Added check for default: true, but no autoselect.
@forbesjo forbesjo merged commit ee594e5 into master Oct 25, 2018
@forbesjo forbesjo deleted the set-default-tracks branch October 25, 2018 16:53
@alex-barstow alex-barstow mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesinger gesinger gesinger left review comments

@forbesjo forbesjo forbesjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkatsev @forbesjo @gesinger @mrocajr