Add unit tests and closed-caption autoselect to fix(subtitles) PR #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for autoselect for closed-caption and subtitles
gkatsev
reviewed
Oct 24, 2018
src/media-groups.js
Outdated
| @@ -568,7 +568,7 @@ export const initialize = { | |||
| const track = tech.addRemoteTextTrack({ | |||
| id: properties.instreamId, | |||
| kind: 'captions', | |||
| enabled: false, | |||
| enabled: properties.default && properties.autoselect, | |||
There was a problem hiding this comment.
the property name should be default
There was a problem hiding this comment.
properties.default as opposed to (properties.default && properties.autoselect)?
There was a problem hiding this comment.
gesinger
reviewed
Oct 24, 2018
test/media-groups.test.js
Outdated
| @@ -726,6 +726,7 @@ function(assert) { | |||
| assert.ok(this.mediaTypes[type].groups.sub2[1].playlistLoader, | |||
| 'playlistLoader created'); | |||
| assert.ok(this.mediaTypes[type].tracks.en, 'created text track'); | |||
| assert.equal(this.mediaTypes[type].tracks.en.default, true, 'en track auto selected'); | |||
There was a problem hiding this comment.
This seems to be testing that the default property is set, rather than it being auto selected.
There was a problem hiding this comment.
I think that's fine? Actually selecting the caption by default is the job of Video.js, so, there's no need to test that behavior here (or override it). But we do need to make sure that the signal is passed to Video.js properly.
forbesjo
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.