Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests and closed-caption autoselect to fix(subtitles) PR #270

Merged
merged 4 commits into from
Oct 25, 2018
Merged

Add unit tests and closed-caption autoselect to fix(subtitles) PR #270

merged 4 commits into from
Oct 25, 2018

Commits on Oct 24, 2018

  1. - Added autoselect property to closed-caption default 

    - Added tests for autoselect for closed-caption and subtitles
    @mrocajr
    mrocajr committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    e90eb13 View commit details
    Browse the repository at this point in the history

  2. - Changed captions enabled to default

    @mrocajr
    mrocajr committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    2846732 View commit details
    Browse the repository at this point in the history

  3. - Check for default in test rather than enabled

    @mrocajr
    mrocajr committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    071ad94 View commit details
    Browse the repository at this point in the history

  4. - Added check for default: true, but no autoselect.

    @mrocajr
    mrocajr committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    f0b2c49 View commit details
    Browse the repository at this point in the history