Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacheEncryptionKeys has no effect with subtitle streams #973

Closed
phloxic opened this issue Oct 15, 2020 · 12 comments
Closed

cacheEncryptionKeys has no effect with subtitle streams #973

phloxic opened this issue Oct 15, 2020 · 12 comments

Comments

@phloxic
Copy link
Contributor

phloxic commented Oct 15, 2020 •
edited
Loading

Description

Reduced test case can be found here.

Steps to reproduce

  1. AES encrypted HLS source with subtitle stream
  2. set cacheEncryptionKeys: true
  3. play and monitor GETting of key files

Results

Keys for video renditions are fetched once, key(s) for subtitles are re-fetched and not cached.

Expected

Key files for subtitle streams should be cached too.
@welcome
Copy link

welcome bot commented Oct 15, 2020

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated label Dec 25, 2020
@phloxic
Copy link
Contributor Author

phloxic commented Dec 31, 2020

Still happening with 7.11.1:
Screen Shot 2020-12-31 at 15 22 54

@phloxic
Copy link
Contributor Author

phloxic commented Jan 11, 2021

Could the "outdated" label be removed? imho the issue is not outdated. Thank you.

@stale stale bot removed the outdated label Jan 11, 2021
@phloxic
Copy link
Contributor Author

phloxic commented Jan 11, 2021

oh, thank you bot

@gkatsev
Copy link
Member

gkatsev commented Nov 30, 2021

Looks like a long time ago I wrote a response to this, and then this got lost in the churn. Thankfully, Firefox saved my response, which is posted below. A PR would be helpful, as it's clearly something we're unlikely to get to any time soon.

Looks like our VTT Segment Loader isn't aware of that option, but our regular segment loader is. It should be relatively straight forward to add.

@phloxic
Copy link
Contributor Author

phloxic commented Dec 1, 2021

Wanted to look into this anyway, thanks for the nudge. Will have a go.

For the time being I had brushed this under the carpet somewhat by shamelessly increasing targetduration for vtt.

phloxic added a commit to phloxic/http-streaming that referenced this issue Dec 1, 2021
@phloxic
fix: cache aes keys for text tracks (videojs#973)
087327b
phloxic added a commit to phloxic/http-streaming that referenced this issue Feb 24, 2022
@phloxic
fix: cache aes keys for text tracks (videojs#973)
9a4ee37
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated label Apr 17, 2022
@phloxic
Copy link
Contributor Author

phloxic commented Apr 17, 2022

unstale

@stale stale bot removed the outdated label Apr 17, 2022
gesinger added a commit that referenced this issue May 26, 2022
@phloxic @gesinger
fix: cache aes keys for text tracks (#973) (#1228)
721e1bf 
* fix: cache aes keys for text tracks (#973)

* Move encryption key caching tests to common loader tests to cover VTT loader

Co-authored-by: Garrett Singer <gesinger@gmail.com>
kchang-brightcove pushed a commit that referenced this issue Aug 1, 2022
@phloxic @gesinger @kchang-brightcove
fix: cache aes keys for text tracks (#973) (#1228)
999091a 
* fix: cache aes keys for text tracks (#973)

* Move encryption key caching tests to common loader tests to cover VTT loader

Co-authored-by: Garrett Singer <gesinger@gmail.com>
misteroneill pushed a commit that referenced this issue Aug 19, 2022
@phloxic @gesinger @misteroneill
fix: cache aes keys for text tracks (#973) (#1228)
66a5b17 
* fix: cache aes keys for text tracks (#973)

* Move encryption key caching tests to common loader tests to cover VTT loader

Co-authored-by: Garrett Singer <gesinger@gmail.com>
@ghost
Copy link

ghost commented Mar 25, 2023

Any update onto this? Would also interest me to have this fixed ...

@phloxic
Copy link
Contributor Author

phloxic commented Mar 26, 2023

@venomone - this is fixed I believe.

@phloxic
Copy link
Contributor Author

phloxic commented Jun 3, 2023

Fixed via 66a5b17

@phloxic phloxic closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phloxic @gkatsev