fix: wait for endedtimeline event from transmuxer when reaching the end of a timeline #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd of a timeline Previously, when the end of a timeline was reached (i.e., the last segment in a given timeline was appended), `endTimeline` would be called, but the loader would not wait for the event to finish. This lead to issues where segment information came back after a segment is considered done with processing, and segment information could be dropped. This fix waits for the `endedtimeline` message from the transmuxer before it considers the transmux complete.
brandonocasey
previously approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the end of a timeline was reached (i.e., the last
segment in a given timeline was appended),
endTimelinewould becalled, but the loader would not wait for the event to finish. This
lead to issues where segment information came back after a segment is
considered done with processing, and segment information could be
dropped. This fix waits for the
endedtimelinemessage from thetransmuxer before it considers the transmux complete.
Requirements Checklist