fix: Only add sidxMapping on successful sidx request and parse. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Mar 29, 2021
| @@ -112,18 +113,6 @@ export const parseMasterXml = ({ masterXml, srcUrl, clientOffset, sidxMapping }) | |||
| return master; | |||
| }; | |||
|
|
|||
| export const generateSidxKey = (sidxInfo) => { | |||
There was a problem hiding this comment.
This function already existed in mpd-parser, now that we export it, use that one.
brandonocasey
commented
Mar 29, 2021
src/dash-playlist-loader.js
Outdated
| @@ -358,6 +347,7 @@ export default class DashPlaylistLoader extends EventTarget { | |||
|
|
|||
| const fin = (err, request) => { | |||
| if (this.requestErrored_(err, request, startingState)) { | |||
| delete sidxMapping[sidxKey]; | |||
There was a problem hiding this comment.
This is the fix
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
- Coverage 86.09% 86.06% -0.03%
==========================================
Files 38 38
Lines 8905 8923 +18
Branches 1996 1998 +2
==========================================
+ Hits 7667 7680 +13
- Misses 1238 1243 +5
Continue to review full report at Codecov.
|
brandonocasey
changed the title
gkatsev
previously approved these changes
Mar 29, 2021
gkatsev
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires videojs/mpd-parser#123
Fixes our
Angel One - Widevine, fmp4, webm, subs, alternate audio tracksand i'm sure it fixes others.