Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set audio status on loaders when setting up media groups #1126

Merged
merged 3 commits into from
May 19, 2021

Commits on May 5, 2021

  1. fix: set audio status on loaders when setting up media groups

    Although the audio status is set in onTrackChanged for media groups, and
    the function is called when the media groups are first set up, the track
    is not always considered changed. This means that for demuxed audio, the
    main loader may still think it should be using its own audio itself,
    leading to issues when crossing discontinuities (i.e., the main loader
    will cross the discontinuity before waiting for the audio loader to be
    ready, leading to audio timestamps that aren't correct).
    
    This change ensures that the audio status is set on setup, regardless of
    whether the track is considered changed. Subsequent changes are handled
    in onTrackChanged.
    gesinger committed May 5, 2021
    Configuration menu
    Copy the full SHA
    de9c88d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    306a6c7 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Configuration menu
    Copy the full SHA
    073deaf View commit details
    Browse the repository at this point in the history