Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Caption services (608/708) metadata #1138

Merged
merged 19 commits into from
Jun 11, 2021
Merged

feat: Caption services (608/708) metadata #1138

merged 19 commits into from
Jun 11, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jun 4, 2021

Add an option for caption services metadata in case the user wants to specify labels for 608/708 captions, override the ones provided in the manifest, or needs to add more information like character encoding (this isn't currently available but will be added some time in the future).
For HLS, an EXT-X-MEDIA tag can be specified with an INSTREAM-ID attribute. We already support this. https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-08#section-4.4.6.1
This PR updated mpd-parser which uses the ANSI 214 supplamental spec section 7.2 to parse out the same information from MPD files. videojs/mpd-parser#131.

Adds a property called captionServices which has properties of the caption service IDs like CC1 or SERVICE1 and allows a user to specify a language and label.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1138 (22351a9) into main (44905d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
+ Coverage   86.44%   86.45%   +0.01%     
==========================================
  Files          39       39              
  Lines        9471     9489      +18     
  Branches     2183     2189       +6     
==========================================
+ Hits         8187     8204      +17     
- Misses       1284     1285       +1     
Impacted Files Coverage Δ
src/media-groups.js 98.66% <100.00%> (-0.32%) ⬇️
src/util/text-tracks.js 89.62% <100.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44905d4...22351a9. Read the comment docs.

README.md Outdated Show resolved Hide resolved
src/util/text-tracks.js Outdated Show resolved Hide resolved
src/util/text-tracks.js Show resolved Hide resolved
src/util/text-tracks.js Show resolved Hide resolved
test/master-playlist-controller.test.js Outdated Show resolved Hide resolved
test/master-playlist-controller.test.js Show resolved Hide resolved
gkatsev and others added 2 commits June 11, 2021 12:02
Co-authored-by: Garrett Singer <gesinger@gmail.com>
@gkatsev gkatsev merged commit 39782c6 into main Jun 11, 2021
@gkatsev gkatsev deleted the caption-services branch June 11, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants