feat: use new mpd-parser API for handling live DASH refreshes #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support the new mpd-parser API, whenever a DASH manifest refreshes, the prior parsed manifest object needs to be passed in as `previousManifest`. This change adds support for that. NOTE: this is to support an upcoming feature in mpd-parser: videojs/mpd-parser#152
Codecov Report
@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 86.31% 86.30% -0.01%
==========================================
Files 39 39
Lines 9796 9797 +1
Branches 2278 2278
==========================================
Hits 8455 8455
- Misses 1341 1342 +1
Continue to review full report at Codecov.
|
gkatsev
previously approved these changes
Dec 15, 2021
|
Once we get the mpd-parser change from videojs/mpd-parser#152 released and updated here, we can merge this PR. |
gkatsev
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the new mpd-parser API, whenever a DASH manifest
refreshes, the prior parsed manifest object needs to be passed in as
previousManifest. This change adds support for that.NOTE: this is to support an upcoming feature in mpd-parser:
videojs/mpd-parser#152
Requirements Checklist