Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(playack): make live dash test take 5 seconds #1235

Merged
merged 1 commit into from
Dec 10, 2021
Merged

test(playack): make live dash test take 5 seconds #1235

merged 1 commit into from
Dec 10, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1235 (3edb745) into main (7495ead) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          39       39           
  Lines        9796     9796           
  Branches     2278     2278           
=======================================
  Hits         8454     8454           
  Misses       1342     1342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495ead...3edb745. Read the comment docs.

@gkatsev
Copy link
Member Author

gkatsev commented Dec 10, 2021

Increasing the playFor timer seems to make the test more reliable, particularly, on Firefox. I've run the tests twice.
Since this is a test-only change, and it only involves changing the playFor from 2 to 5, I'm merging it without review.

@gkatsev gkatsev merged commit b66e124 into main Dec 10, 2021
@gkatsev gkatsev deleted the 5-seconds branch December 10, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant