Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: retain playlist attributes when refreshing live media playlists #1270

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

mister-ben
Copy link
Contributor

Description

On a live playlist with media groups, subsequent fetches of the media playlist overwrite the playlist attributes with an empty object. This affects part of the rendiiton selection flow, including the audio only test. On an audio-only stream this impacts playback, as no audio only stream is found. This can result in cycling through the renditions, playing an unnecessarily low rendtion, or for streams with manifest redundancy, that playback stops.

Specific Changes proposed

Updates th playlist with the merged playlist rather than the unmodifed newly parsed playlist. This should have been the behaviour already.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1270 (10edac7) into main (b98877d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1270   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          39       39           
  Lines        9840     9840           
  Branches     2292     2292           
=======================================
  Hits         8492     8492           
  Misses       1348     1348           
Impacted Files Coverage Δ
src/playlist-loader.js 95.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98877d...10edac7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants