Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix IE11 encrypted VTT tests by using an actual encrypted VTT segment #1291

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

gesinger
Copy link
Contributor

Also moves the tests under a new module called "Segment Key Caching."

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1291 (b5f8450) into main (721e1bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          39       39           
  Lines        9842     9842           
  Branches     2293     2293           
=======================================
  Hits         8494     8494           
  Misses       1348     1348           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721e1bf...b5f8450. Read the comment docs.

@gesinger gesinger merged commit 97e02fb into videojs:main Jul 6, 2022
kchang-brightcove pushed a commit that referenced this pull request Aug 1, 2022
…egment (#1291)

* Update script and docs for creating subtitlesEncrypted.vtt
misteroneill pushed a commit that referenced this pull request Aug 19, 2022
…egment (#1291)

* Update script and docs for creating subtitlesEncrypted.vtt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants