fix: resume loading on segment timeout for experimentalBufferBasedABR
#1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there was a segment timeout and `experimentalBufferBasedABR` was set to `true`, then the main segment loader would stay in a `READY` state and never resume loading segments. This is because the buffer based ABR path doesn't follow the same flow as non buffer based ABR, where a new playlist would be loaded immediately and it would trigger a load. Buffer based ABR may determine that no rendition change should be made, despite the timeout, leading to nothing happening. This change makes the call to load explicit, but only for buffer based ABR on timeouts.
evanfarina
reviewed
Oct 13, 2022
| }); | ||
| this.mainSegmentLoader_.on('timeout', () => { | ||
| if (this.experimentalBufferBasedABR) { | ||
| // If a rendition change is needed, then it would've be done on `bandwidthupdate`. |
Codecov Report
@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 86.33% 86.34% +0.01%
==========================================
Files 39 39
Lines 9857 9859 +2
Branches 2298 2299 +1
==========================================
+ Hits 8510 8513 +3
+ Misses 1347 1346 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Oct 14, 2022
misteroneill
approved these changes
Nov 18, 2022
misteroneill
pushed a commit
that referenced
this pull request
Nov 21, 2022
Previously, if there was a segment timeout and `experimentalBufferBasedABR` was set to `true`, then the main segment loader would stay in a `READY` state and never resume loading segments. This is because the buffer based ABR path doesn't follow the same flow as non buffer based ABR, where a new playlist would be loaded immediately and it would trigger a load. Buffer based ABR may determine that no rendition change should be made, despite the timeout, leading to nothing happening. This change makes the call to load explicit, but only for buffer based ABR on timeouts.
misteroneill
pushed a commit
that referenced
this pull request
Nov 21, 2022
Previously, if there was a segment timeout and `experimentalBufferBasedABR` was set to `true`, then the main segment loader would stay in a `READY` state and never resume loading segments. This is because the buffer based ABR path doesn't follow the same flow as non buffer based ABR, where a new playlist would be loaded immediately and it would trigger a load. Buffer based ABR may determine that no rendition change should be made, despite the timeout, leading to nothing happening. This change makes the call to load explicit, but only for buffer based ABR on timeouts.
misteroneill
pushed a commit
that referenced
this pull request
Nov 21, 2022
Previously, if there was a segment timeout and `experimentalBufferBasedABR` was set to `true`, then the main segment loader would stay in a `READY` state and never resume loading segments. This is because the buffer based ABR path doesn't follow the same flow as non buffer based ABR, where a new playlist would be loaded immediately and it would trigger a load. Buffer based ABR may determine that no rendition change should be made, despite the timeout, leading to nothing happening. This change makes the call to load explicit, but only for buffer based ABR on timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was a segment timeout and
experimentalBufferBasedABRwas set totrue, then the main segment loader would stay in aREADYstate and never resume loading segments. This is because the buffer based ABR path doesn't follow the same flow as non buffer based ABR, where a new playlist would be loaded immediately and it would trigger a load. Buffer based ABR may determine that no rendition change should be made, despite the timeout, leading to nothing happening. This change makes the call to load explicit, but only for buffer based ABR on timeouts.This addresses #1287
Test Changes
Changed
experimentalBufferBasedABRdoes make a playlist selection onbandwidthupdatebandwidthupdatewhen there's only one playlist. This warning doesn't always make sense, as a timeout that causes abandwidthupdatewould be a connection issue, rather than a stream issue.Added
timeoutevent on timeouttimeoutif experimentalBufferBasedABRTesting
[EXPERIMENTAL] Use Buffer Level for ABR (reloads player)and setpreloadtonone.Requirements Checklist