Sync controller media sequence strategy #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzianis-dashkevich
commented
Nov 30, 2023
•
dzianis-dashkevich
commented
- implement a new sync strategy based on the media sequence
- implement exact match for sync controller
- fix fast quality switch race condition
- implement force timestamp offset after resync loader
added 8 commits
November 30, 2023 14:07
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## align-3-5-2 #1458 +/- ##
===============================================
- Coverage 86.12% 85.97% -0.15%
===============================================
Files 42 42
Lines 10586 10673 +87
Branches 2441 2456 +15
===============================================
+ Hits 9117 9176 +59
- Misses 1469 1497 +28 ☔ View full report in Codecov by Sentry. |
wseymour15
approved these changes
Nov 30, 2023
Co-authored-by: Walter Seymour <walterseymour15@gmail.com>
adrums86
approved these changes
Dec 4, 2023
|
@adrums86, I will add it in the next PRs |
dzianis-dashkevich
deleted the
sync-controller-media-sequence-strategy
branch
dzianis-dashkevich
added a commit
that referenced
this pull request
Dec 4, 2023
…rEachSegment and remove replaceSegmentsUntil (#1457) * Revert "fix: check for transmuxer for vtt-segment-loader (#1452)" This reverts commit b4dd748. * Revert "fix: fix several issues with calculate timestamp offset for each segment (#1451)" This reverts commit 3bbc6ef. * Revert "fix: replaceSegmentsUntil flag resetting too early (#1444)" This reverts commit af39ba5. * Revert "fix: prevent wrapping in resetMainLoaderReplaceSegments (#1439)" This reverts commit 719b7f4. * Revert "feat: Add feature flag to calculate timestampOffset for each segment to handle streams with corrupted pts or dts timestamps (#1426)" This reverts commit 2355ddc. * Revert "fix: fastQualityChange refactor (#1414)" This reverts commit 4590bdd. * cherry-pick: use transmuxer time info instead of probeTs * feat: sync controller media sequence strategy (#1458) * feat: add media sequence sync strategy * fix: fix current media sequence increment * chore: update logs * feat: use exact segment match in sync-controller * fix: fix race condition for a fast quality switch * chore: add additional logs for choose next request * feat: force timestamp after resync * chore: fix or skip tests * Update src/segment-loader.js Co-authored-by: Walter Seymour <walterseymour15@gmail.com> --------- Co-authored-by: Dzianis Dashkevich <ddashkevich@brightcove.com> Co-authored-by: Walter Seymour <walterseymour15@gmail.com> --------- Co-authored-by: Dzianis Dashkevich <ddashkevich@brightcove.com> Co-authored-by: Walter Seymour <walterseymour15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.