fix: Clear the blacklist for other playlists if final rendition errors #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Feb 7, 2019
src/master-playlist-controller.js
Outdated
| videojs.log.warn('Removing all playlists from the blacklist because the last ' + | ||
| 'rendition is about to be blacklisted.'); | ||
| playlists.forEach((playlist) => { | ||
| delete playlist.excludeUntil; |
There was a problem hiding this comment.
I think this was a bug from the original PR, but we need to check to ensure we don't clear incompatible playlists from the blacklist (where excludeUntil === Infinity).
|
Good to go once we ignore |
…sts on final playlist
|
Not sure why the test for commit f805916 is showing as passed, it failed as you can see here: https://travis-ci.org/videojs/http-streaming/builds/514306305#L2492. However, it's supposed to fail to show that the test works as expected. The build for the fix commit (b37e4fc) is here: https://travis-ci.org/videojs/http-streaming/builds/514308525. |
|
Lastest build passes: https://travis-ci.org/videojs/http-streaming/builds/514317942 |
|
Looks good to me |
gkatsev
approved these changes
Apr 1, 2019
brandonocasey
pushed a commit
that referenced
this pull request
Apr 25, 2019
#396) Ignore unsupported renditions (those with an excludeUntil of Infinity)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
videojs/videojs-contrib-hls#1083
Description
Before the behavior is we never blacklist the final request and wait up to 5 minutes for other playlists' blacklist duration to be cleared. Change the behavior as follows:
Requirements Checklist