fix: Fix video playback freezes caused by not using tech current time #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Feb 20, 2019
gkatsev
approved these changes
Feb 20, 2019
|
A potential test for this is to make a middleware that always returns a "weird" time, i.e., a time that's different from what the tech returns for a regular play. For example, on the first play request, have the middleware return 5s. Presumably, that would trigger this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is somewhat hard to reproduce as it only happens when another middleware reports a
currentTimethat is not the same as what vhs suggests.