Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only fire seekablechange on a change #415

Merged
merged 1 commit into from
Mar 5, 2019
Merged

fix: only fire seekablechange on a change #415

merged 1 commit into from
Mar 5, 2019

Conversation

brandonocasey
Copy link
Contributor

Description

A lot of the time we call seekablechange and log seekable changes when seekable is the same as it previously was.

misteroneill
misteroneill approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@misteroneill misteroneill merged commit a4c056e into master Mar 5, 2019
@misteroneill misteroneill deleted the fix/seekable-change branch March 5, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@forbesjo forbesjo forbesjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @misteroneill @forbesjo