fix: inline json version #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/inline-json-version
branch
from
cdfdae2
to
95f9d3f
Compare
This was referenced Oct 1, 2020
|
Aftering updating mux.js and vhs-utils tags to latest, I think this is working as expected now locally. Was a bit tricky to get it working, but I think it was my local setup. |
gkatsev
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ideally we would be able to specify regex externals in videojs-generate-rollup-config, but we cannot currently. For now we will use @rollup/plugin-replace to fix issues with downstream webpack builds caused by importing json directly.