feat: parse out Location element and return the first one #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/inheritAttributes.js
Outdated
| const mpdAttributes = parseAttributes(mpd); | ||
| const mpdBaseUrls = buildBaseUrls([ manifestUri ], findChildren(mpd, 'BaseURL')); | ||
|
|
||
| mpdAttributes.sourceDuration = mpdAttributes.mediaPresentationDuration || 0; | ||
| mpdAttributes.NOW = NOW; | ||
| mpdAttributes.clientOffset = clientOffset; | ||
|
|
||
| return flatten(periods.map(toAdaptationSets(mpdAttributes, mpdBaseUrls))); | ||
| if (locations.length) { | ||
| mpdAttributes.location = getContent(locations[0]); |
There was a problem hiding this comment.
I see in the spec that location can be specified 0 to n times. I think that means that we could have multiple locations, would it make more sense to follow the spec here and support multiple?
There was a problem hiding this comment.
I was going to say since we aren't going to support it in VHS right now, what's the point, but making it return an array from here isn't that hard and would mean that we or others wouldn't need an mpd-parser update should we want to start supporting multiple Location elements.
There was a problem hiding this comment.
Making the change, I'll then update VHS to just get the first one (for now, at least)
gesinger
approved these changes
Aug 12, 2020
brandonocasey
approved these changes
Aug 12, 2020
RomeroDiver
pushed a commit
to Arc-Soft/mpd-parser
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: