feat: remove default value of 0 for minimumUpdatePeriod #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve conflicts with location parsing
alex-barstow
force-pushed
the
remove-mup-default
branch
from
df2d51b
to
adca6d9
Compare
gkatsev
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
LGTM.
When we merge we should make sure to have BREAKING CHANGE: footer in the commit message as per the convention https://github.com/videojs/conventional-changelog-videojs/blob/master/convention.md
gkatsev
approved these changes
Aug 27, 2020
brandonocasey
added a commit
that referenced
this pull request
Nov 17, 2020
brandonocasey
added a commit
that referenced
this pull request
Nov 17, 2020
RomeroDiver
pushed a commit
to Arc-Soft/mpd-parser
that referenced
this pull request
Dec 7, 2020
BREAKING CHANGE: The minimumUpdatePeriod property is now omitted from parsed output if it is not present in the manifest, rather than using a default value of 0. This is to allow differentiation between cases when a value of 0 is present in the manifest and when no value is provided.
RomeroDiver
pushed a commit
to Arc-Soft/mpd-parser
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We cannot currently differentiate between cases when the
minimumUpdatePerioddoes not exist vs. when it is 0, since we set 0 as the default value in the first case. Since it is valid for theminimumUpdatePeriodto be either 0 or absent, we need to remove this default value.