This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Rename _isPlaying to _playbackStarted. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck, so that pause will not trigger if the video has ended and pause() is called.
|
LGTM. |
| @@ -291,7 +291,7 @@ package com.videojs.providers{ | |||
| public function pause():void{ | |||
| var alreadyPaused = _isPaused; | |||
| _ns.pause(); | |||
| if(!alreadyPaused){ | |||
| if(_playbackStarted && !alreadyPaused){ | |||
|
👍 |
|
Looks good to me. Could this affect other ad plugins some how? |
|
The new version of the ad plugin needs these changes. |
|
Ad plugins using the current version of contrib-ads should be positively impacted as well with this change (and Gary's which we pulled in earlier). It takes care of an issue with preroll behavior and autoplay settings which were causing the swf to report the paused state incorrectly. |
heff
added a commit
that referenced
this pull request
Mar 17, 2015
Rename _isPlaying to _playbackStarted.
heff
added a commit
to heff/video-js-swf
that referenced
this pull request
Mar 17, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert removal of _isPlaying check, so that pause will not trigger if the video has ended and pause() is called. Still make sure that we capture the paused state before we call pause though.