Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Updated updated RTMP provider. fixes #8 #27

Merged
merged 4 commits into from
Jul 16, 2013
Merged

Conversation

bdeitte
Copy link
Contributor

@bdeitte bdeitte commented Jul 11, 2013

This pull request has the commits from #17 within it. It also:

  • fixes the merge issue with pull 17
  • adds a few more empty methods required by NetConnection with some streams to not throw errors

These changes have been tested against a wide variety of Akamai and Limelight rtmp streams, including live streams. The only issues to report are that the end screen is black and that controls scrubbing performance can be choppy. Nothing found that I think should prevent this pull request.

The related video.js request: videojs/video.js#634

@heff
Copy link
Member

heff commented Jul 16, 2013

Thanks @iamjem and @bdeitte. Looks great.

heff added a commit that referenced this pull request Jul 16, 2013
Updated updated RTMP provider. fixes #8
@heff heff merged commit 50b73bf into videojs:master Jul 16, 2013
@heff
Copy link
Member

heff commented Jul 18, 2013

@iamjem @bdeitte, do we know if the core lib changes still apply to this update?
videojs/video.js#605

@bdeitte
Copy link
Contributor Author

bdeitte commented Jul 18, 2013

Replacing my old comment here, as I'm getting pull requests jumbled up. As I posted in 605, you should pull in videojs/video.js#634 now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants