Skip to content

Commit

Permalink
Merge branch 'main' into feat/improve-types
Browse files Browse the repository at this point in the history
  • Loading branch information
gjanblaszczyk committed Apr 11, 2023
2 parents 4fbf576 + 1491d71 commit 6269f80
Show file tree
Hide file tree
Showing 102 changed files with 936 additions and 727 deletions.
15 changes: 9 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: General issue
description: Report a general issue with Video.js
labels: "needs: triage, bug"
labels: "needs: triage"
body:
- type: markdown
attributes:
Expand All @@ -9,9 +9,10 @@ body:
* If you are not reporting a bug, but want to ask a general question, use [discussions](https://github.com/videojs/video.js/discussions) instead.
* Check the [FAQ](https://videojs.com/guides/faqs) and [troubleshooting guides](https://videojs.com/guides/troubleshooting).
* If there is an existing open issue for exactly the same problem, comment there instead.
* However, be careful not to comment on old, closed issues, the new comment is unlikely to be noticed.
* Take care to make sure it is really the exact same issue. If in doubt, open as a new issue.
* If the issue is with a specific plugin, it's often better to open an issue on the plugin repository instead.
* However, be careful not to comment on old and closed issues. Your new comment is unlikely to be noticed.
* Take care to make sure it is really the exact same issue. Conflating tangentially related issues is counterproductive. If in doubt, open as a new issue.
* Add useful new information, such as a new reproducible case to help narrow down the issue.
* If the issue is with a specific plugin, it's generally better to open an issue on the plugin repository instead.
* Please do take the time to give detailed information, and include a test case. A detailed issue with actionable information will get a better response than a vague anecdote.
- type: textarea
id: description
Expand All @@ -24,12 +25,14 @@ body:
required: true
- type: input
id: testcase
validations:
required: true
attributes:
label: Reduced test case
description: |
Please add a URL to a [reduced test case](https://stackoverflow.com/help/minimal-reproducible-example) where the issue can be observed. We have a [starter template](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0) on Codepen.
Providing a test case will improve the chances of someone being able to identify the issue quickly.
For a playback problem, including the stream URL is essential.
**Without a test case** it's unlikely your issue can be actioned.
For a playback problem, including the stream URL is _essential._
placeholder: https://
- type: textarea
id: str
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
should-skip-job: ${{steps.skip-check.outputs.should_skip}}
steps:
- id: skip-check
uses: fkirc/skip-duplicate-actions@v2.1.0
uses: fkirc/skip-duplicate-actions@v5.3.0
with:
github_token: ${{github.token}}

Expand All @@ -30,10 +30,10 @@ jobs:
runs-on: ${{matrix.os}}
steps:
- name: checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: read node version from .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
shell: bash
id: nvm

Expand All @@ -47,7 +47,7 @@ jobs:
run: pulseaudio -D

- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '${{steps.nvm.outputs.NVMRC}}'
cache: npm
Expand All @@ -61,7 +61,7 @@ jobs:
run: npm i --prefer-offline --no-audit

- name: run npm test
uses: GabrielBB/xvfb-action@v1
uses: coactions/setup-xvfb@v1
with:
run: npm run test

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
# We need to fetch the entire history as conventional-changelog needs
# access to any number of git commits to build the changelog.
with:
fetch-depth: 0

- name: read node version from .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
shell: bash
id: nvm

- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '${{steps.nvm.outputs.NVMRC}}'
cache: npm
Expand All @@ -45,7 +45,7 @@ jobs:
run: node -e "console.log(require('./build/current-changelog.js')())" > CHANGELOG-LATEST.md

- name: get dashed package version for netlify
run: echo ::set-output name=VERSION::$(node -e "process.stdout.write(require('./package.json').version.split('.').join('-'))")
run: echo "VERSION=$(node -e "process.stdout.write(require('./package.json').version.split('.').join('-'))")" >> $GITHUB_OUTPUT
id: get-version
shell: bash
if: env.NETLIFY_BASE != ''
Expand Down Expand Up @@ -76,13 +76,13 @@ jobs:
S3_KEY: ${{ secrets.AWS_S3_KEY }}
steps:
- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3

- name: npm install video.js
run: npm install "video.js@$VJS_VERSION"

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v2
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_S3_SECRET }}
Expand Down
3 changes: 2 additions & 1 deletion .jsdoc.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"class": "link-vjs"
},
{
"title": "v8.0.2 source",
"title": "v8.2.1 source",
"link": "https://github.com/videojs/video.js",
"class": "link-gh"
},
Expand Down Expand Up @@ -59,6 +59,7 @@
}
},
"plugins": [
"node_modules/jsdoc-tsimport-plugin/index.js",
"plugins/markdown",
"build/jsdoc-typeof-plugin"
],
Expand Down
28 changes: 28 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
<a name="8.3.0"></a>
# [8.3.0](https://github.com/videojs/video.js/compare/v8.2.1...v8.3.0) (2023-04-05)

### Features

* Add document picture-in-picture support ([#8113](https://github.com/videojs/video.js/issues/8113)) ([0c72805](https://github.com/videojs/video.js/commit/0c72805))

### Bug Fixes

* Ensure additional components update on languagechange ([#8175](https://github.com/videojs/video.js/issues/8175)) ([b489bc5](https://github.com/videojs/video.js/commit/b489bc5))
* improved accessibility for time display ([#8182](https://github.com/videojs/video.js/issues/8182)) ([c35c45b](https://github.com/videojs/video.js/commit/c35c45b)), closes [#8143](https://github.com/videojs/video.js/issues/8143)
* **lang:** improve Italian labels ([#8193](https://github.com/videojs/video.js/issues/8193)) ([fefd525](https://github.com/videojs/video.js/commit/fefd525))
* **lang:** Improve Persian translation ([#7991](https://github.com/videojs/video.js/issues/7991)) ([af33e39](https://github.com/videojs/video.js/commit/af33e39))
* **lang:** Improve translations for mute and unmute ([#8227](https://github.com/videojs/video.js/issues/8227)) ([629000b](https://github.com/videojs/video.js/commit/629000b))
* **lang:** Update nl.json ([#8135](https://github.com/videojs/video.js/issues/8135)) ([b60d34b](https://github.com/videojs/video.js/commit/b60d34b))
* reset progress bar fully when player is reset ([#8160](https://github.com/videojs/video.js/issues/8160)) ([71343d1](https://github.com/videojs/video.js/commit/71343d1))
* **types:** Add jsdoc plugin to handle ts-style imports ([#8225](https://github.com/videojs/video.js/issues/8225)) ([61bd74d](https://github.com/videojs/video.js/commit/61bd74d))

### Chores

* **package:** fix out of sync package-lock.json ([#8228](https://github.com/videojs/video.js/issues/8228)) ([fe94c5d](https://github.com/videojs/video.js/commit/fe94c5d))
* Update CI and release workflows ([#8214](https://github.com/videojs/video.js/issues/8214)) ([882f3af](https://github.com/videojs/video.js/commit/882f3af))
* update issue template ([#8212](https://github.com/videojs/video.js/issues/8212)) ([e42b859](https://github.com/videojs/video.js/commit/e42b859))

### Documentation

* Update jsdoc template for better usability on mobile ([#8048](https://github.com/videojs/video.js/issues/8048)) ([c1a1f9c](https://github.com/videojs/video.js/commit/c1a1f9c))

<a name="8.2.1"></a>
## [8.2.1](https://github.com/videojs/video.js/compare/v8.2.0...v8.2.1) (2023-03-15)

Expand Down
Loading

0 comments on commit 6269f80

Please sign in to comment.